jenkins-bot has submitted this change and it was merged.

Change subject: distutils build_modules requires str on Python 2
......................................................................


distutils build_modules requires str on Python 2

When setup parameter packages contains unicode, distutils fails with:

    TypeError: 'package' must be a string (dot-separated), list, or tuple

Bug: T114487
Change-Id: Ibf70fb66f001b6d11b99c21904ed22015452b421
---
M setup.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  XZise: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/setup.py b/setup.py
index fe4b1b1..9441c84 100644
--- a/setup.py
+++ b/setup.py
@@ -190,9 +190,9 @@
     maintainer='The Pywikibot team',
     maintainer_email='pywiki...@lists.wikimedia.org',
     license='MIT License',
-    packages=['pywikibot'] + [package
-                              for package in find_packages()
-                              if package.startswith('pywikibot.')],
+    packages=[str(name)] + [package
+                            for package in find_packages()
+                            if package.startswith('pywikibot.')],
     install_requires=dependencies,
     dependency_links=dependency_links,
     extras_require=extra_deps,

-- 
To view, visit https://gerrit.wikimedia.org/r/243362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf70fb66f001b6d11b99c21904ed22015452b421
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: XZise <commodorefabia...@gmx.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to