Christopher Johnson (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/243592

Change subject: adds static bindings to DT to avoid deprecated shiny js
......................................................................

adds static bindings to DT to avoid deprecated shiny js

Change-Id: I02d9c98eee696832b41b0cd5eae9e971829d2f8e
---
M server.R
M ui.R
2 files changed, 6 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/analytics/dashboard 
refs/changes/92/243592/1

diff --git a/server.R b/server.R
index 08d8003..33b110e 100644
--- a/server.R
+++ b/server.R
@@ -19,13 +19,13 @@
         updateTabItems(session, "tabs", input$switchtab)
     })
     #Home
-    latest_frame <- data.frame(tail(wikidata_edits,1), 
tail(wikidata_active_users,1), 
tail(wikidata_pages,1),tail(wikidata_gooditems,1),tail(wikidata_facebook,1),tail(wikidata_googleplus,1),tail(wikidata_twitter,1),tail(wikidata_identica,1),tail(wikidata_irc,1))
+   latest_frame <- data.frame(tail(wikidata_edits,1), 
tail(wikidata_active_users,1), 
tail(wikidata_pages,1),tail(wikidata_gooditems,1),tail(wikidata_facebook,1),tail(wikidata_googleplus,1),tail(wikidata_twitter,1),tail(wikidata_identica,1),tail(wikidata_irc,1))
     dt_latest <- data.table(latest_frame)
     dt_latest <- setnames(dt_latest, c("Date", "Edits", "date.1", "Active 
Users", "date.2", "Pages", "date.3", "Content Pages", "date.4", "Facebook 
Likes", "date.5", "Google+ Followers", "date.6","Twitter Followers", 
"date.7","Identica Followers", "date.8","IRC"))
     dt_latest <- dt_latest[, list(Date, Edits, `Active Users`,Pages,`Content 
Pages`,`Facebook Likes`,`Google+ Followers`,`Twitter Followers`,`Identica 
Followers`,IRC)]
     df_out <- t(dt_latest)
-    output$wikidata_daily_summary_table <- renderDataTable(
-      datatable(df_out, class = "display compact", colnames = c("Property", 
"Value"), caption = "Statistics Today"))
+    output$wikidata_daily_summary_table <- DT::renderDataTable(
+     datatable(df_out, class = "display compact", colnames = c("Property", 
"Value"), caption = "Statistics Today"))
     # http://wikiba.se/metrics#RecentEdits
     wikidata_recent_edits <- wikidata_edits[which(wikidata_edits$date > 
existing_date - 7),]
     df_recent_edits <- wikidata_recent_edits[order(wikidata_recent_edits$date, 
decreasing =TRUE),]
@@ -109,8 +109,7 @@
     })
     aggr_props <- aggregate(wikidata_daily_getclaims_property_use$count, 
by=list(wikidata_daily_getclaims_property_use$property), FUN = sum)
     aggr_props_ordered <- aggr_props[order(aggr_props$x, decreasing = TRUE),]
-    output$wikidata_daily_getclaims_property_use_table 
<-renderDataTable(aggr_props_ordered, options = list(pageLength = 50))
-    # http://wikiba.se/metrics#Edits
+    output$wikidata_daily_getclaims_property_use_table 
<-DT::renderDataTable(datatable(aggr_props_ordered, class = "display compact", 
colnames = c("Property", "Value"), rownames = FALSE, options = list(pageLength 
= 50, autoWidth = TRUE, columnDefs = list(list(className = 'dt-left', targets = 
c(0,1))))))
     output$wikidata_edits_plot <- renderDygraph({
       make_dygraph(wikidata_edits,
                    "", "Edits", "Wikidata Edits")
diff --git a/ui.R b/ui.R
index 64b48d8..6f56c26 100644
--- a/ui.R
+++ b/ui.R
@@ -58,7 +58,7 @@
     tabItem(tabName="dashboard",
             includeMarkdown("./assets/dashboard.md"),
             selectInput('switchtab', "Metric Selector", c("Home" = 
"dashboard", "Edits" = "wikidata_edits", "Pages" = "wikidata_pages", "Active 
Editors" = "wikidata_community_health")),
-            dataTableOutput("wikidata_daily_summary_table")),
+            DT::dataTableOutput("wikidata_daily_summary_table")),
     tabItem(tabName = "wikidata_daily_edits_delta",
             dygraphOutput("wikidata_daily_edits_delta_plot"),
             tags$br(),
@@ -83,7 +83,7 @@
             fluidRow(
               uiOutput("metric_meta_getclaims_title")
             ),
-            dataTableOutput("wikidata_daily_getclaims_property_use_table")),
+            
DT::dataTableOutput("wikidata_daily_getclaims_property_use_table")),
     tabItem(tabName = "wikidata_edits",
             fluidRow(
               infoBoxOutput("editdelta")

-- 
To view, visit https://gerrit.wikimedia.org/r/243592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02d9c98eee696832b41b0cd5eae9e971829d2f8e
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/analytics/dashboard
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to