Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/244720
Change subject: Hygiene: Remove obsolete cookie
......................................................................
Hygiene: Remove obsolete cookie
The cookie mwUploadsFunnel (set by Nearby and Watchlist) isn't used anywhere,
so there is no reason to set it.
Change-Id: I1136afd916f0559d4f8577cad2e9ad7fffe80760
---
M resources/mobile.nearby/Nearby.js
M resources/mobile.watchlist/WatchList.js
2 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/20/244720/1
diff --git a/resources/mobile.nearby/Nearby.js
b/resources/mobile.nearby/Nearby.js
index 5e5bbe2..11f3156 100644
--- a/resources/mobile.nearby/Nearby.js
+++ b/resources/mobile.nearby/Nearby.js
@@ -230,10 +230,6 @@
$( this ).attr( 'id', 'nearby-page-list-item-'
+ i );
} ).on( 'click', function () {
window.location.hash = $( this ).attr( 'id' );
- // name funnel for watchlists to catch
subsequent uploads
- $.cookie( 'mwUploadsFunnel', 'nearby', {
- expires: new Date( new Date().getTime()
+ 60000 )
- } );
} );
// Restore the offset
diff --git a/resources/mobile.watchlist/WatchList.js
b/resources/mobile.watchlist/WatchList.js
index 6719ab1..03ea561 100644
--- a/resources/mobile.watchlist/WatchList.js
+++ b/resources/mobile.watchlist/WatchList.js
@@ -11,9 +11,6 @@
* @uses InfiniteScroll
*/
WatchList = WatchstarPageList.extend( {
- events: {
- 'mousedown a.title': 'onTitleClick'
- },
/** @inheritdoc */
initialize: function ( options ) {
var lastTitle;
@@ -51,15 +48,6 @@
postRender: function () {
WatchstarPageList.prototype.postRender.apply( this );
this.infiniteScroll.enable();
- },
- /**
- * Save title clicks
- */
- onTitleClick: function () {
- // name funnel for watchlists to catch subsequent
uploads
- $.cookie( 'mwUploadsFunnel', 'watchlist', {
- expires: new Date( new Date().getTime() + 60000
)
- } );
},
/**
* Loads pages from the api and triggers render.
--
To view, visit https://gerrit.wikimedia.org/r/244720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1136afd916f0559d4f8577cad2e9ad7fffe80760
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
