Prtksxna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/246185

Change subject: Media upload: Initialize booklet before setting file on drag 
drop
......................................................................

Media upload: Initialize booklet before setting file on drag drop

Calling initialize will clear all fields including the
OO.ui.SelectFileWidget that was just set.

Bug: T40031
Change-Id: Ibc7ddafae9cb7718372520245a356938f4731479
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/85/246185/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index b17291f..e39fba7 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -1086,13 +1086,13 @@
 
                        this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
 
+                       // Reset upload booklet
+                       this.mediaUploadBooklet.initialize();
+
                        if ( data.file ) {
                                this.searchTabs.setCard( 'upload' );
                                this.mediaUploadBooklet.setFile( data.file );
                        }
-
-                       // Reset upload booklet
-                       this.mediaUploadBooklet.initialize();
                }, this );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/246185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc7ddafae9cb7718372520245a356938f4731479
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to