Muehlenhoff has submitted this change and it was merged.
Change subject: Move the base::firewall include into the impala role
......................................................................
Move the base::firewall include into the impala role
Change-Id: I829a22910f3d15530e4d3a91c4bea6d3290d741e
---
M manifests/role/analytics/impala.pp
M manifests/site.pp
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Muehlenhoff: Verified; Looks good to me, approved
diff --git a/manifests/role/analytics/impala.pp
b/manifests/role/analytics/impala.pp
index d4a4ecf..3fef7ae 100644
--- a/manifests/role/analytics/impala.pp
+++ b/manifests/role/analytics/impala.pp
@@ -31,6 +31,7 @@
#
class role::analytics::impala::master {
include role::analytics::impala
+ include base::firewall
# The llama-master package stupidly creates the llama user
# with a non system uid. This causes our admin module to
diff --git a/manifests/site.pp b/manifests/site.pp
index 26fd0ed..83f3167 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -150,7 +150,6 @@
include role::analytics::clients
include role::analytics::impala::master
include role::logging::udp2log::misc
- include base::firewall
}
# analytics1027 hosts some frontend web interfaces to Hadoop
--
To view, visit https://gerrit.wikimedia.org/r/246221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I829a22910f3d15530e4d3a91c4bea6d3290d741e
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits