Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/248829
Change subject: Simplify snaklistview edit mode stopping in referenceview
......................................................................
Simplify snaklistview edit mode stopping in referenceview
Currently, the referenceview throws away the `snaklistviews` no matter if
`dropValue` is true or not.
Change-Id: I012fc7cfa543c8046e597c852ceda435760e0a8b
---
M view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
1 file changed, 5 insertions(+), 28 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/29/248829/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
b/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
index c38cf44..a33f276 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
@@ -250,7 +250,7 @@
this.disable();
if ( dropValue ) {
- this._stopEditingReferenceSnaks( dropValue );
+ this._stopEditingReferenceSnaks();
this.enable();
this.element.removeClass( 'wb-edit' );
@@ -262,7 +262,7 @@
.done( function( savedReference ) {
self.options.value = savedReference;
- self._stopEditingReferenceSnaks( dropValue );
+ self._stopEditingReferenceSnaks();
self.enable();
@@ -290,41 +290,18 @@
/**
* @private
- *
- * @param {boolean} dropValue
*/
- _stopEditingReferenceSnaks: function( dropValue ) {
+ _stopEditingReferenceSnaks: function() {
var listview = this.$listview.data( 'listview' );
- $.each( listview.value(), function() {
- this.stopEditing( dropValue );
-
- if ( dropValue && !this.value() ) {
- // Remove snaklistview from referenceview if no
snakviews are left in that
- // snaklistview:
- listview.removeItem( this.element );
- }
+ listview.items().each( function() {
+ listview.removeItem( $( this ) );
} );
-
- this.clear();
if ( this.options.value ) {
$.each(
this.options.value.getSnaks().getGroupedSnakLists(), function() {
listview.addItem( this );
} );
- }
- },
-
- /**
- * Clears the widget's content.
- * @since 0.5
- */
- clear: function() {
- var listview = this.$listview.data( 'listview' ),
- items = listview.items();
-
- for ( var i = 0; i < items.length; i++ ) {
- listview.removeItem( items.eq( i ) );
}
},
--
To view, visit https://gerrit.wikimedia.org/r/248829
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I012fc7cfa543c8046e597c852ceda435760e0a8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
