Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249304
Change subject: VE: Use ace editor for JSON editing
......................................................................
VE: Use ace editor for JSON editing
MWAceEditorWidget falls back to plain text input behaviour
if the ace editor module is not available.
Change-Id: I1ba9e839589644e797eca12a0a6ffaea9ef5aae3
---
M modules/ve-graph/ve.ui.MWGraphDialog.js
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Graph
refs/changes/04/249304/1
diff --git a/modules/ve-graph/ve.ui.MWGraphDialog.js
b/modules/ve-graph/ve.ui.MWGraphDialog.js
index c083bc5..2b0add1 100644
--- a/modules/ve-graph/ve.ui.MWGraphDialog.js
+++ b/modules/ve-graph/ve.ui.MWGraphDialog.js
@@ -180,16 +180,19 @@
.setIcon( 'code' )
.setLabel( ve.msg( 'graph-ve-dialog-edit-page-raw' ) );
- this.jsonTextInput = new ve.ui.WhitespacePreservingTextInputWidget( {
+ this.jsonTextInput = new ve.ui.MWAceEditorWidget( {
autosize: true,
classes: [ 've-ui-mwGraphDialog-json' ],
- maxRows: 25,
+ maxRows: 22,
multiline: true,
validate: this.validateRawData
} );
// Make sure JSON is LTR
- this.jsonTextInput.setRTL( false );
+ this.jsonTextInput
+ .setLanguage( 'json' )
+ .toggleLineNumbers( false )
+ .setRTL( false );
jsonTextField = new OO.ui.FieldLayout( this.jsonTextInput, {
label: ve.msg( 'graph-ve-dialog-edit-field-raw-json' ),
--
To view, visit https://gerrit.wikimedia.org/r/249304
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ba9e839589644e797eca12a0a6ffaea9ef5aae3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Graph
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
