Cscott has uploaded a new change for review. https://gerrit.wikimedia.org/r/249338
Change subject: Fix CLI installer when --dbname is not specified on command line. ...................................................................... Fix CLI installer when --dbname is not specified on command line. When installing without an explicit `--dbname` argument on the command line, the database is installed with the default value of $wgDBname from DefaultSettings.php (which is `my_wiki`), but then the LocalSettings.php file is written with the line: $wgDBname = ""; which overrides the default value and makes the wiki unable to connect to the database created by the installer. Adding `wgDBname` to the `$defaultVarNames` list fixes this problem. Change-Id: I3792be9675aabe00b5497ed4203b12b89da8dc3a --- M includes/installer/Installer.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/38/249338/1 diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php index ba0e38f..dd12cea 100644 --- a/includes/installer/Installer.php +++ b/includes/installer/Installer.php @@ -169,6 +169,7 @@ 'wgEnotifUserTalk', 'wgEnotifWatchlist', 'wgEmailAuthentication', + 'wgDBname', 'wgDBtype', 'wgDiff3', 'wgImageMagickConvertCommand', -- To view, visit https://gerrit.wikimedia.org/r/249338 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3792be9675aabe00b5497ed4203b12b89da8dc3a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Cscott <canan...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits