Filippo Giunchedi has submitted this change and it was merged.
Change subject: base: reflow and expand parameters documentation
......................................................................
base: reflow and expand parameters documentation
Change-Id: Ib413cc68f78ef8bb4bd01ddcac9e409a136efab3
---
M modules/base/manifests/service_unit.pp
1 file changed, 31 insertions(+), 26 deletions(-)
Approvals:
Filippo Giunchedi: Verified; Looks good to me, approved
Giuseppe Lavagetto: Looks good to me, approved
diff --git a/modules/base/manifests/service_unit.pp
b/modules/base/manifests/service_unit.pp
index ce22c99..40d9272 100644
--- a/modules/base/manifests/service_unit.pp
+++ b/modules/base/manifests/service_unit.pp
@@ -8,40 +8,44 @@
#
# === Parameters ===
#
-#[*ensure*]
-# Is the usual metaparameter, defaults to present
+# [*ensure*]
+# Is the usual metaparameter, defaults to present.
+# Note that the underlying service is also controlled by this metaparameter
+# (unless $declare_service is false), in other words a truthy value here will
+# ensure => running and conversely a falsey value will ensure => stopped.
#
-#[*template_name*]
-# String, default $name. Init file template pathnames are formed
-# using the pattern "$module/initscripts/$template_name.$initsystem.erb"
+# [*template_name*]
+# String, default $name. Init file template pathnames are formed
+# using the pattern "$module/initscripts/$template_name.$initsystem.erb"
#
-#[*systemd*]
-# Boolean - set it to true to make the resource include personalized
-# init file. As this is used to You are expected to put them in a
-# specific subdirectory of the current module, which is
-# $module/initscripts/$template_name.systemd.erb for systemd (and
-# similarly for other init systems)
+# [*systemd*]
+# Boolean - set it to true to make the resource include personalized
+# init file. As this is used to You are expected to put them in a
+# specific subdirectory of the current module, which is
+# $module/initscripts/$template_name.systemd.erb for systemd (and
+# similarly for other init systems)
#
-#[*upstart*]
-# As the preceding param, but for upstart scripts
+# [*upstart*]
+# As the preceding param, but for upstart scripts
#
-#[*sysvinit*]
-# As the preceding param, but for traditional sysvinit scripts
+# [*sysvinit*]
+# As the preceding param, but for traditional sysvinit scripts
#
-#[*strict*]
-# Boolean - if true (default), only allows to have customized scripts
-# for all init systems; if false allows to use standard scripts from
-# the distro (e.g. memcached will need a custom systemd unit, but use
-# the standard init file on upstart).
+# [*strict*]
+# Boolean - if true (default), only allows to have customized scripts
+# for all init systems; if false allows to use standard scripts from
+# the distro (e.g. memcached will need a custom systemd unit, but use
+# the standard init file on upstart).
#
-#[*refresh*]
-# Boolean - tells puppet if a change in the config should notify the service
directly
+# [*refresh*]
+# Boolean - tells puppet if a change in the config should notify the service
+# directly
#
-#[*declare_service*]
-# Boolean - tells puppet if a service {} stanza is required or not
+# [*declare_service*]
+# Boolean - tells puppet if a service {} stanza is required or not
#
-#[*service_params*]
-# An hash of parameters that we want to apply to the service resource
+# [*service_params*]
+# An hash of parameters that we want to apply to the service resource
#
# === Example ===
#
@@ -58,6 +62,7 @@
# }
# }
# }
+
define base::service_unit (
$ensure = present,
$systemd = false,
--
To view, visit https://gerrit.wikimedia.org/r/249717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib413cc68f78ef8bb4bd01ddcac9e409a136efab3
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
