Ottomata has submitted this change and it was merged.
Change subject: dataset::cron::job now runs rsync command via bash instead of sh
......................................................................
dataset::cron::job now runs rsync command via bash instead of sh
This allows for fancier shell path wildcards
Change-Id: I3c30c9e922c494a075858a5888e776baf9b25226
---
M modules/dataset/manifests/cron/job.pp
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Ottomata: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/dataset/manifests/cron/job.pp
b/modules/dataset/manifests/cron/job.pp
index b5f0145..2717111 100644
--- a/modules/dataset/manifests/cron/job.pp
+++ b/modules/dataset/manifests/cron/job.pp
@@ -23,7 +23,9 @@
cron { "dataset-${title}":
ensure => $ensure,
- command => "/usr/bin/rsync -rt --delete --chmod=go-w ${source}/
${destination}/",
+ # Run command via bash instead of sh so that $source can be fancier
+ # wildcards or globs (e.g. /path/to/{dir1,dir1}/ok/data/ )
+ command => "bash -c '/usr/bin/rsync -rt --delete --chmod=go-w
${source}/ ${destination}/'",
environment => "MAILTO=${mailto}",
user => $user,
require => User[$user],
--
To view, visit https://gerrit.wikimedia.org/r/249744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c30c9e922c494a075858a5888e776baf9b25226
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <o...@wikimedia.org>
Gerrit-Reviewer: Ottomata <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
