Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249876
Change subject: mw.config.get doesn't work that way.
......................................................................
mw.config.get doesn't work that way.
You can't give it a fallback value. This is causing JS errors in
production.
Bug: T116758
Change-Id: Ia459a42250ca6e030025781005e40204f1ede58e
---
M resources/ext.relatedArticles.readMore.bootstrap/index.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles
refs/changes/76/249876/1
diff --git a/resources/ext.relatedArticles.readMore.bootstrap/index.js
b/resources/ext.relatedArticles.readMore.bootstrap/index.js
index 464f6ca..dd988f6 100644
--- a/resources/ext.relatedArticles.readMore.bootstrap/index.js
+++ b/resources/ext.relatedArticles.readMore.bootstrap/index.js
@@ -1,9 +1,12 @@
( function ( $ ) {
- var relatedArticles = mw.config.get( 'wgRelatedArticles', [] ).slice(
0, 4 ),
+ var relatedArticles = mw.config.get( 'wgRelatedArticles' ) || [],
config = mw.config.get( [ 'skin', 'wgNamespaceNumber',
'wgMFMode', 'wgIsMainPage' ] ),
module;
+ // Limit number of related articles to 4 (more of them increases
likelihood of reader ignoring).
+ relatedArticles = relatedArticles.slice( 0, 4 );
+
/**
* Retrieves the data required to render a card.
*
--
To view, visit https://gerrit.wikimedia.org/r/249876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia459a42250ca6e030025781005e40204f1ede58e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
