Gergő Tisza has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250300
Change subject: Expand trigger area for play button contrast change to whole
player
......................................................................
Expand trigger area for play button contrast change to whole player
The play button is partially transparent and can be hard to notice
on certain backgrounds. It becomes brighter when moused over which
is not much help in finding it. Make it change color when the whole
player is moused over instead (this is how e.g. YouTube handles
button color).
This also makes color change acually work for thumbnails
(.PopUpMediaTransform) in Chrome, before it was always the non-hover
style that was applied. I could not figure out the reason for that,
seemed like a Chrome bug.
Bug: T117344
Change-Id: I3f141d8854eaa9f4a4d87ec80555a25fc81a2ec7
---
M MwEmbedModules/EmbedPlayer/resources/skins/kskin/PlayerSkinKskin.css
M resources/PopUpThumbVideo.css
2 files changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/00/250300/1
diff --git
a/MwEmbedModules/EmbedPlayer/resources/skins/kskin/PlayerSkinKskin.css
b/MwEmbedModules/EmbedPlayer/resources/skins/kskin/PlayerSkinKskin.css
index f6c675d..d29b1a7 100644
--- a/MwEmbedModules/EmbedPlayer/resources/skins/kskin/PlayerSkinKskin.css
+++ b/MwEmbedModules/EmbedPlayer/resources/skins/kskin/PlayerSkinKskin.css
@@ -33,7 +33,7 @@
}
}
/*.ui-state-default */
-.k-player .play-btn-large:hover {
+.k-player:hover .play-btn-large {
background: url(images/ksprite.png) no-repeat 0px -377px;
}
diff --git a/resources/PopUpThumbVideo.css b/resources/PopUpThumbVideo.css
index 5f97d7f..72aefac 100644
--- a/resources/PopUpThumbVideo.css
+++ b/resources/PopUpThumbVideo.css
@@ -8,7 +8,7 @@
/* @embed */
background-image:url('player_big_play_button.png');
}
-.PopUpMediaTransform a .play-btn-large :hover {
+.PopUpMediaTransform:hover a .play-btn-large {
/* @embed */
background-image:url('player_big_play_button_hover.png');
}
--
To view, visit https://gerrit.wikimedia.org/r/250300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f141d8854eaa9f4a4d87ec80555a25fc81a2ec7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
