Yaron Koren has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250681
Change subject: Removed unnecessary inclusion of SF CSS in helper pages
......................................................................
Removed unnecessary inclusion of SF CSS in helper pages
The call to include them, addExtensionStyle(), is deprecated anyway,
so it works out well.
Change-Id: I3328d4a85a5719740c986893218ffacb80ce1851
---
M specials/SF_CreateCategory.php
M specials/SF_CreateClass.php
M specials/SF_CreateForm.php
M specials/SF_CreateProperty.php
M specials/SF_CreateTemplate.php
5 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms
refs/changes/81/250681/1
diff --git a/specials/SF_CreateCategory.php b/specials/SF_CreateCategory.php
index 25ca993..ade9a69 100644
--- a/specials/SF_CreateCategory.php
+++ b/specials/SF_CreateCategory.php
@@ -124,7 +124,6 @@
$text .= "\t" . Html::rawElement( 'div', array( 'class' =>
'editButtons' ), $editButtonsText ) . "\n";
$text .= "\t</form>\n";
- $wgOut->addExtensionStyle( $sfgScriptPath .
"/skins/SemanticForms.css" );
$wgOut->addHTML( $text );
}
diff --git a/specials/SF_CreateClass.php b/specials/SF_CreateClass.php
index fe88bf2..e1c9e21 100644
--- a/specials/SF_CreateClass.php
+++ b/specials/SF_CreateClass.php
@@ -203,13 +203,13 @@
}
$this->setHeaders();
- $wgOut->addExtensionStyle( $sfgScriptPath .
"/skins/SemanticForms.css" );
+
$numStartingRows = 5;
self::addJavascript( $numStartingRows );
$createAll = $wgRequest->getCheck( 'createAll' );
if ( $createAll ) {
- // Guard against cross-site request forgeries (CSRF).
+ // Guard against cross-site request forgeries (CSRF).
$validToken = $this->getUser()->matchEditToken(
$wgRequest->getVal( 'csrf' ), 'CreateClass' );
if ( !$validToken ) {
$text = "This appears to be a cross-site
request forgery; canceling save.";
diff --git a/specials/SF_CreateForm.php b/specials/SF_CreateForm.php
index 11f3897..cf25bc5 100644
--- a/specials/SF_CreateForm.php
+++ b/specials/SF_CreateForm.php
@@ -398,7 +398,6 @@
END;
- $wgOut->addExtensionStyle( $sfgScriptPath .
"/skins/SemanticForms.css" );
$wgOut->addHTML( $text );
//Don't submit the form if enter is pressed on a text input box
or a select
diff --git a/specials/SF_CreateProperty.php b/specials/SF_CreateProperty.php
index 86fea62..651167f 100644
--- a/specials/SF_CreateProperty.php
+++ b/specials/SF_CreateProperty.php
@@ -181,7 +181,6 @@
$text .= "\t" . Html::rawElement( 'div', array( 'class' =>
'editButtons' ), $edit_buttons ) . "\n";
$text .= "\t</form>\n";
- $wgOut->addExtensionStyle( $sfgScriptPath .
"/skins/SemanticForms.css" );
$wgOut->addScript( '<script type="text/javascript">' .
$javascript_text . '</script>' );
$wgOut->addHTML( $text );
}
diff --git a/specials/SF_CreateTemplate.php b/specials/SF_CreateTemplate.php
index b0d5f9b..f958672 100644
--- a/specials/SF_CreateTemplate.php
+++ b/specials/SF_CreateTemplate.php
@@ -345,7 +345,6 @@
END;
- $wgOut->addExtensionStyle( $sfgScriptPath .
"/skins/SemanticForms.css" );
$wgOut->addHTML( $text );
}
--
To view, visit https://gerrit.wikimedia.org/r/250681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3328d4a85a5719740c986893218ffacb80ce1851
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <yaro...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
