Lupo has uploaded a new change for review. Change subject: Cleanup: missing "var"s, unused locals, etc. ......................................................................
Cleanup: missing "var"s, unused locals, etc. Minor cleanup: - add some missing variable declarations. - add a few mising semicolons. - remove some unused variables. - remove two "var"s that had no effect (redeclaration of already existing variable "files" in mw.UploadWizardUpload.js) - mark one place in mw.UploadWizardUpload.js with XXX. The variable is unused, but I'm unsure about the original programmer's intention. Could be removed, or refactored such that it is used. mw.ApiQueryImageInfo.js appears to be unused; there are more specialized functions in UploadWizardUpload for this. It is also not in the ResourceLoader modules. And its implementation appears buggy (function success() is unused.) File deleted. Change-Id: Idd0067b58fd1d9d5cbe45b66e54ac12ed65e81b8 --- D resources/mw.ApiQueryImageInfo.js M resources/mw.DestinationChecker.js M resources/mw.FlickrChecker.js M resources/mw.IframeTransport.js M resources/mw.UploadWizard.js M resources/mw.UploadWizardDeed.js M resources/mw.UploadWizardDetails.js M resources/mw.UploadWizardUpload.js M resources/mw.UploadWizardUploadInterface.js M resources/mw.UtilitiesTime.js 10 files changed, 19 insertions(+), 101 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/13/39513/1 -- To view, visit https://gerrit.wikimedia.org/r/39513 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idd0067b58fd1d9d5cbe45b66e54ac12ed65e81b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Lupo <lupo.bugzi...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
