Mooeypoo has uploaded a new change for review. https://gerrit.wikimedia.org/r/250849
Change subject: Prep for mobile rewrite in Echo ...................................................................... Prep for mobile rewrite in Echo Fix event documentation and add mobile target for ext.echo.ui Change-Id: I86131293ec83359fa2dc6eaccf35a2824e0cf051 --- M Resources.php M modules/viewmodel/mw.echo.dm.NotificationsModel.js 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/49/250849/1 diff --git a/Resources.php b/Resources.php index 1e30139..0c449b3 100644 --- a/Resources.php +++ b/Resources.php @@ -81,7 +81,7 @@ 'mytalk', 'mypreferences' ), - 'targets' => array( 'desktop' ), + 'targets' => array( 'desktop', 'mobile' ), ), 'ext.echo.dm' => $echoResourceTemplate + array( 'scripts' => array( diff --git a/modules/viewmodel/mw.echo.dm.NotificationsModel.js b/modules/viewmodel/mw.echo.dm.NotificationsModel.js index f3c8a24..1446678 100644 --- a/modules/viewmodel/mw.echo.dm.NotificationsModel.js +++ b/modules/viewmodel/mw.echo.dm.NotificationsModel.js @@ -62,14 +62,14 @@ /** * @event unseenChange - * @param {number} count Number of unseen items + * @param {mw.echo.dm.NotificationItem} items An array of the unseen items * * Items' seen status has changed */ /** * @event unreadChange - * @param {number} count Number of unread items + * @param {mw.echo.dm.NotificationItem} items An array of the unread items * * Items' read status has changed */ -- To view, visit https://gerrit.wikimedia.org/r/250849 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I86131293ec83359fa2dc6eaccf35a2824e0cf051 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits