AndyRussG has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250896
Change subject: Stronger check for Object.defineProperty, to handle IE8
......................................................................
Stronger check for Object.defineProperty, to handle IE8
Bug: T113013
Change-Id: I60be3232682da64467e86a4c2eae5a53ab107adb
---
M resources/subscribing/ext.centralNotice.display.js
1 file changed, 11 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/96/250896/1
diff --git a/resources/subscribing/ext.centralNotice.display.js
b/resources/subscribing/ext.centralNotice.display.js
index d709dfd..0e74c85 100644
--- a/resources/subscribing/ext.centralNotice.display.js
+++ b/resources/subscribing/ext.centralNotice.display.js
@@ -104,17 +104,20 @@
if ( typeof Object.defineProperty === 'function' ) {
- Object.defineProperty( cn, 'data', {
- get: function() { return
cn.internal.state.getData(); }
- } );
+ try {
+ Object.defineProperty( cn, 'data', {
+ get: function() { return
cn.internal.state.getData(); }
+ } );
- } else {
+ return;
- // FIXME For browsers that don't support
defineProperty, we don't
- // fully respect our internal contract with the state
object to
- // manage data, since we assume the object reference
won't change.
- cn.data = cn.internal.state.getData();
+ } catch (e) {}
}
+
+ // FIXME For browsers that don't support defineProperty, we
don't
+ // fully respect our internal contract with the state object to
+ // manage data, since we assume the object reference won't
change.
+ cn.data = cn.internal.state.getData();
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/250896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60be3232682da64467e86a4c2eae5a53ab107adb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <andrew.green...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
