Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250899
Change subject: Remove WikiPage::doQuickEdit
......................................................................
Remove WikiPage::doQuickEdit
Change-Id: If56f790b8a29b2262cba0feff7a96312c69cdb0c
---
M RELEASE-NOTES-1.27
M includes/page/WikiPage.php
M tests/phpunit/includes/page/WikiPageTest.php
3 files changed, 1 insertion(+), 38 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/99/250899/1
diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index f549620..8f82f69 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -96,6 +96,7 @@
* Removed "loaderScripts" option from ResourceLoaderFileModule class.
* Removed ORM-like wrapper added in 1.20.
* LinkCache::getGoodLinks and LinkCache::getBadLinks were removed (deprecated
in 1.26).
+* WikiPage::doQuickEdit() was removed.
== Compatibility ==
diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index 2d5cb78..ff8050b 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -2284,25 +2284,6 @@
* The article must already exist; link tables etc
* are not updated, caches are not flushed.
*
- * @param string $text Text submitted
- * @param User $user The relevant user
- * @param string $comment Comment submitted
- * @param bool $minor Whereas it's a minor modification
- *
- * @deprecated since 1.21, use doEditContent() instead.
- */
- public function doQuickEdit( $text, User $user, $comment = '', $minor =
0 ) {
- ContentHandler::deprecated( __METHOD__, "1.21" );
-
- $content = ContentHandler::makeContent( $text,
$this->getTitle() );
- $this->doQuickEditContent( $content, $user, $comment, $minor );
- }
-
- /**
- * Edit an article without doing all that other stuff
- * The article must already exist; link tables etc
- * are not updated, caches are not flushed.
- *
* @param Content $content Content submitted
* @param User $user The relevant user
* @param string $comment Comment submitted
diff --git a/tests/phpunit/includes/page/WikiPageTest.php
b/tests/phpunit/includes/page/WikiPageTest.php
index a21fc8a..0a46f8a 100644
--- a/tests/phpunit/includes/page/WikiPageTest.php
+++ b/tests/phpunit/includes/page/WikiPageTest.php
@@ -213,25 +213,6 @@
}
/**
- * @covers WikiPage::doQuickEdit
- */
- public function testDoQuickEdit() {
- global $wgUser;
-
- $this->hideDeprecated( "WikiPage::doQuickEdit" );
-
- // NOTE: assume help namespace will default to wikitext
- $page = $this->createPage( "Help:WikiPageTest_testDoQuickEdit",
"original text" );
-
- $text = "quick text";
- $page->doQuickEdit( $text, $wgUser, "testing q" );
-
- # ---------------------
- $page = new WikiPage( $page->getTitle() );
- $this->assertEquals( $text, $page->getText() );
- }
-
- /**
* @covers WikiPage::doQuickEditContent
*/
public function testDoQuickEditContent() {
--
To view, visit https://gerrit.wikimedia.org/r/250899
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If56f790b8a29b2262cba0feff7a96312c69cdb0c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
