Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250955
Change subject: Fix references counter when saving whole statement
......................................................................
Fix references counter when saving whole statement
Bug: T117668
Change-Id: Id7d239b50904d39d0494594ddc40c153207db9d0
---
M view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/55/250955/1
diff --git a/view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
b/view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
index d84bb50..5ed7278 100644
--- a/view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
+++ b/view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
@@ -132,8 +132,8 @@
return this._afterStopEditing( dropValue );
} else {
this._save()
- .done( function() {
- self.options.value = self.value();
+ .done( function( savedValue ) {
+ self.options.value = savedValue || self.value();
self._afterStopEditing( dropValue )
.done( function() {
deferred.resolve( dropValue );
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index 6fae93a..681370d 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -689,12 +689,16 @@
* @protected
*/
_stopEditingReferences: function( dropValue ) {
- $.each( this._referencesListview.value(), function ( key,
referenceView ) {
- if( !dropValue ){
- referenceView.value( referenceView.value() );
+ var references = !dropValue &&
this.options.value.getReferences().toArray();
+
+ $.each( this._referencesListview.value(), function ( i,
referenceView ) {
+ if ( !dropValue ) {
+ referenceView.value( references[ i ] );
}
referenceView.stopEditing();
} );
+
+ this._drawReferencesCounter();
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/250955
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7d239b50904d39d0494594ddc40c153207db9d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
