Aude has submitted this change and it was merged.

Change subject: (bug 43195) Refactor and test LangLinkHandler.
......................................................................


(bug 43195) Refactor and test LangLinkHandler.

This refactors LangLinkHandler to get rid of global state and
provides unit tests.

For testing, this change also introduces MockRepository along
with tests for that class.

Change-Id: I2c0fb19d47b7643bb7580430fc5b93daab990716
---
M client/WikibaseClient.hooks.php
M client/WikibaseClient.php
M client/includes/LangLinkHandler.php
M client/includes/NoLangLinkHandler.php
A client/tests/phpunit/MockRepository.php
A client/tests/phpunit/MockRepositoryTest.php
A client/tests/phpunit/includes/LangLinkHandlerTest.php
7 files changed, 1,461 insertions(+), 109 deletions(-)

Approvals:
  Aude: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/39034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2c0fb19d47b7643bb7580430fc5b93daab990716
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to