Jonas Kress (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251487
Change subject: When hitting cancel references should be thrown away
......................................................................
When hitting cancel references should be thrown away
Bug: T117963
Change-Id: I7a81c79fd981af723fb9212c35acb3ba611de1bb
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 4 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/87/251487/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index 7ab5757..b149b68 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -683,7 +683,7 @@
this._stopEditingQualifiers( dropValue );
this._rankSelector.stopEditing( dropValue );
- this._stopEditingReferences( dropValue );
+ this._recreateReferences();
return PARENT.prototype._afterStopEditing.call( this, dropValue
);
},
@@ -691,15 +691,9 @@
/**
* @protected
*/
- _stopEditingReferences: function( dropValue ) {
- var references = !dropValue &&
this.options.value.getReferences().toArray();
-
- $.each( this._referencesListview.value(), function ( i,
referenceView ) {
- if ( !dropValue ) {
- referenceView.value( references[ i ] );
- }
- referenceView.stopEditing();
- } );
+ _recreateReferences: function() {
+ this._referencesListview.option( 'value', this.options.value
+ ? this.options.value.getReferences().toArray()
: [] );
this._drawReferencesCounter();
},
--
To view, visit https://gerrit.wikimedia.org/r/251487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a81c79fd981af723fb9212c35acb3ba611de1bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
