Jonas Kress (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251495
Change subject: Refactor edittoolbar.referenceview ->
removetoolbar.referenceview
......................................................................
Refactor edittoolbar.referenceview -> removetoolbar.referenceview
Bug: T117702
Change-Id: Ibf17413d27f9fc6cb135667620c73c1b259c9e90
---
M repo/resources/Resources.php
M repo/resources/wikibase.ui.entityViewInit.js
R
view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview.js
M view/resources/jquery/wikibase/toolbar/controller/resources.php
4 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/95/251495/1
diff --git a/repo/resources/Resources.php b/repo/resources/Resources.php
index d26067a..3f4eed6 100644
--- a/repo/resources/Resources.php
+++ b/repo/resources/Resources.php
@@ -74,9 +74,9 @@
'jquery.wikibase.toolbarcontroller.definitions.addtoolbar.statementview-referenceview',
'jquery.wikibase.toolbarcontroller.definitions.addtoolbar.statementview-snakview',
'jquery.wikibase.toolbarcontroller.definitions.edittoolbar.entitytermsview',
-
'jquery.wikibase.toolbarcontroller.definitions.edittoolbar.referenceview',
'jquery.wikibase.toolbarcontroller.definitions.edittoolbar.sitelinkgroupview',
'jquery.wikibase.toolbarcontroller.definitions.edittoolbar.statementview',
+
'jquery.wikibase.toolbarcontroller.definitions.removetoolbar.referenceview',
'jquery.wikibase.toolbarcontroller.definitions.removetoolbar.referenceview-snakview',
'jquery.wikibase.toolbarcontroller.definitions.removetoolbar.sitelinkgroupview-sitelinkview',
'jquery.wikibase.toolbarcontroller.definitions.removetoolbar.statementview-snakview',
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index 43249ad..741302d 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -25,10 +25,10 @@
edittoolbar: [
'statementview',
'entitytermsview',
- 'referenceview',
'sitelinkgroupview'
],
removetoolbar: [
+ 'referenceview',
'statementview-snakview',
'referenceview-snakview',
'sitelinkgroupview-sitelinkview'
diff --git
a/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/referenceview.js
b/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview.js
similarity index 91%
rename from
view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/referenceview.js
rename to
view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview.js
index bf44a5e..3875a53 100644
---
a/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/referenceview.js
+++
b/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview.js
@@ -6,8 +6,10 @@
*
* @licence GNU GPL v2+
* @author H. Snater < [email protected] >
+ * @author Adrian Heine
+ * @author Jonas Kress
*/
-$.wikibase.toolbarcontroller.definition( 'edittoolbar', {
+$.wikibase.toolbarcontroller.definition( 'removetoolbar', {
id: 'referenceview',
selector: ':' + $.wikibase.referenceview.prototype.namespace
+ '-' + $.wikibase.referenceview.prototype.widgetName,
diff --git a/view/resources/jquery/wikibase/toolbar/controller/resources.php
b/view/resources/jquery/wikibase/toolbar/controller/resources.php
index 1b775a6..0c66b9a 100644
--- a/view/resources/jquery/wikibase/toolbar/controller/resources.php
+++ b/view/resources/jquery/wikibase/toolbar/controller/resources.php
@@ -94,15 +94,14 @@
),
),
-
'jquery.wikibase.toolbarcontroller.definitions.edittoolbar.referenceview' =>
$moduleTemplate + array(
+
'jquery.wikibase.toolbarcontroller.definitions.removetoolbar.referenceview' =>
$moduleTemplate + array(
'scripts' => array(
- 'definitions/edittoolbar/referenceview.js',
+ 'definitions/removetoolbar/referenceview.js',
),
'dependencies' => array(
- 'jquery.wikibase.edittoolbar',
+ 'jquery.wikibase.removetoolbar',
'jquery.wikibase.referenceview',
'jquery.wikibase.toolbarcontroller',
- 'wikibase.view.ToolbarViewController'
),
),
--
To view, visit https://gerrit.wikimedia.org/r/251495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf17413d27f9fc6cb135667620c73c1b259c9e90
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
