jenkins-bot has submitted this change and it was merged.
Change subject: Put "Support Wikipedia" in the same Nav group as "Settings"
......................................................................
Put "Support Wikipedia" in the same Nav group as "Settings"
Per Design request, there should only be a single divider above Settings,
not below.
Bug: T116591
Change-Id: Iccbef6c3c699eb78e137a1e596f0da17932e5cfc
---
M app/src/main/res/menu/menu_nav_drawer.xml
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
BearND: Looks good to me, approved
Mholloway: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/app/src/main/res/menu/menu_nav_drawer.xml
b/app/src/main/res/menu/menu_nav_drawer.xml
index 62a8c3d..8fedd84 100644
--- a/app/src/main/res/menu/menu_nav_drawer.xml
+++ b/app/src/main/res/menu/menu_nav_drawer.xml
@@ -44,8 +44,6 @@
<item android:id="@+id/nav_item_more"
android:title="@string/settings_item_preferences"
android:icon="@drawable/ic_settings_black_24dp" />
- </group>
- <group android:id="@+id/group_donate">
<item android:id="@+id/nav_item_donate"
android:title="@string/nav_item_donate"
android:icon="@drawable/ic_favorite_black_24dp"/>
--
To view, visit https://gerrit.wikimedia.org/r/251649
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccbef6c3c699eb78e137a1e596f0da17932e5cfc
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
