Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251958
Change subject: Fixed Style/RedundantSelf RuboCop offense
......................................................................
Fixed Style/RedundantSelf RuboCop offense
Bug: T117987
Change-Id: Ic8f8ea705550cebed27d6d4a9920f769da158dd2
---
M .rubocop_todo.yml
M tests/browser/features/support/pages/stash_page.rb
2 files changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/58/251958/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 469fde6..52880e5 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -16,12 +16,6 @@
Metrics/LineLength:
Max: 127
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/RedundantSelf:
- Exclude:
- - 'tests/browser/features/support/pages/stash_page.rb'
-
# Offense count: 14
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForEmptyBraces, SupportedStyles.
diff --git a/tests/browser/features/support/pages/stash_page.rb
b/tests/browser/features/support/pages/stash_page.rb
index 2c04091..f8754c1 100644
--- a/tests/browser/features/support/pages/stash_page.rb
+++ b/tests/browser/features/support/pages/stash_page.rb
@@ -25,9 +25,9 @@
end
def select_language(language)
- self.language_selector_element.click
+ language_selector_element.click
self.language_filter = language
- self.language_filter_element.send_keys :enter
+ language_filter_element.send_keys :enter
end
def translation_element(index = 0)
--
To view, visit https://gerrit.wikimedia.org/r/251958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8f8ea705550cebed27d6d4a9920f769da158dd2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
