Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251963
Change subject: Fixed Lint/UselessAssignment RuboCop offense
......................................................................
Fixed Lint/UselessAssignment RuboCop offense
Bug: T117987
Change-Id: I00b651f44eafdf7b784814882984542b854e2009
---
M .rubocop_todo.yml
M tests/browser/features/support/pages/manage_translator_sandbox_page.rb
2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/63/251963/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 609d272..821f13b 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -6,11 +6,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 1
-Lint/UselessAssignment:
- Exclude:
- - 'tests/browser/features/support/pages/manage_translator_sandbox_page.rb'
-
# Offense count: 48
# Configuration parameters: AllowURI, URISchemes.
Metrics/LineLength:
diff --git
a/tests/browser/features/support/pages/manage_translator_sandbox_page.rb
b/tests/browser/features/support/pages/manage_translator_sandbox_page.rb
index 919fad6..a37171f 100644
--- a/tests/browser/features/support/pages/manage_translator_sandbox_page.rb
+++ b/tests/browser/features/support/pages/manage_translator_sandbox_page.rb
@@ -125,8 +125,6 @@
end
def click_button(label)
- initial_header_text = details_header.text
-
details_button(label).click
# It takes a few moments until Accept and Reject buttons
--
To view, visit https://gerrit.wikimedia.org/r/251963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00b651f44eafdf7b784814882984542b854e2009
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
