Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252584
Change subject: graphite: Clarify monitoring of graphite_threshold for
reqstats.5xx
......................................................................
graphite: Clarify monitoring of graphite_threshold for reqstats.5xx
"HTTP error ratio" is imho very confusing. Every time it shows up
it takes a few tries to figure out which property it is.
Update to make it match the 'reqstats_5xx' monitor for treshold.
Change-Id: I8a42628936b168daa54c36eca67d50aebfce46b2
---
M manifests/role/graphite.pp
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/84/252584/1
diff --git a/manifests/role/graphite.pp b/manifests/role/graphite.pp
index 368535d..2549491 100644
--- a/manifests/role/graphite.pp
+++ b/manifests/role/graphite.pp
@@ -262,8 +262,8 @@
swift::monitoring::graphite_alerts { 'codfw-prod': }
# Monitor production 5xx rates
- monitoring::graphite_threshold { 'reqstats_5xx':
- description => 'HTTP 5xx req/min',
+ monitoring::graphite_threshold { 'reqstats-5xx-threshold':
+ description => 'HTTP 5xx reqs/min threshold',
metric => 'reqstats.5xx',
warning => 250,
critical => 500,
@@ -273,8 +273,8 @@
# Will try to detect anomalies in the requests error ratio;
# if 10% of the last 100 checks is out of forecasted bounds
- monitoring::graphite_anomaly { 'requests_error_ratio':
- description => 'HTTP error ratio anomaly detection',
+ monitoring::graphite_anomaly { 'reqstats-5xx-anomaly':
+ description => 'HTTP 5xx reqs/min anomaly',
metric => 'reqstats.5xx',
warning => 5,
critical => 10,
--
To view, visit https://gerrit.wikimedia.org/r/252584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a42628936b168daa54c36eca67d50aebfce46b2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
