Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/252868

Change subject: Fix QR code generation by using 
ResourceLoader::makeInlineScript()
......................................................................

Fix QR code generation by using ResourceLoader::makeInlineScript()

Untested, but a similar patch unbroke CodeReview (ad038c0625490be55).

Bug: T118511
Change-Id: I522e51ea77abdf88bd71bd24ecb7be570675c1e8
---
M special/SpecialOATH.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OATHAuth 
refs/changes/68/252868/1

diff --git a/special/SpecialOATH.php b/special/SpecialOATH.php
index 29a0783..96c3d6c 100644
--- a/special/SpecialOATH.php
+++ b/special/SpecialOATH.php
@@ -115,11 +115,11 @@
                        . '<br/>'
                        . '<div id="qrcode"></div>';
 
-               $this->getOutput()->addInlineScript(
+               $this->getOutput()->addHTML( ResourceLoader::makeInlineScript(
                        'jQuery("#qrcode").qrcode("otpauth://totp/'
                        . $this->OATHUser->getAccount()
                        . '?secret=' . $secret . '")'
-               );
+               ) );
 
                $this->getOutput()->addHTML( $out );
                $this->getOutput()->addWikiMsg( 
'openstackmanager-scratchtokens' );

-- 
To view, visit https://gerrit.wikimedia.org/r/252868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I522e51ea77abdf88bd71bd24ecb7be570675c1e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OATHAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to