jenkins-bot has submitted this change and it was merged.
Change subject: [DNM] Make Add reference button work in new statement
......................................................................
[DNM] Make Add reference button work in new statement
Bug: T115972
Change-Id: I7105362b8dac335d85d80966872ccd836b7a5a19
---
M view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
M
view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/referenceview.js
2 files changed, 20 insertions(+), 6 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
b/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
index 629f4b6..c38cf44 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
@@ -19,7 +19,7 @@
* @param {jQuery.wikibase.listview.ListItemAdapater} options.listItemAdapter
* @param {wikibase.entityChangers.ReferencesChanger} options.referencesChanger
* Required for saving the `Reference` represented by the widget
instance.
- * @param {string} options.statementGuid
+ * @param {string|null} [options.statementGuid]
* The GUID of the `Statement` the `Reference` represented by the
widget instance belongs to.
* @param {string} [options.helpMessage=mw.msg(
'wikibase-claimview-snak-new-tooltip' )]
* End-user message explaining how to interact with the widget. The
message is most likely to
@@ -89,7 +89,7 @@
* @throws {Error} if a required option is not specified properly.
*/
_create: function() {
- if ( !this.options.statementGuid ||
!this.options.listItemAdapter || !this.options.referencesChanger ) {
+ if ( !this.options.listItemAdapter ||
!this.options.referencesChanger ) {
throw new Error( 'Required option not specified
properly' );
}
diff --git
a/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/referenceview.js
b/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/referenceview.js
index 0b61647..6022161 100644
---
a/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/referenceview.js
+++
b/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/referenceview.js
@@ -20,6 +20,10 @@
},
$container = $referenceview.find(
'.wikibase-toolbar-container' );
+ if ( !referenceview.options.statementGuid ) {
+ return;
+ }
+
if ( !$container.length ) {
$container = $( '<div/>' ).appendTo(
$referenceview.find(
'.wikibase-referenceview-heading' )
@@ -54,8 +58,13 @@
'referenceviewchange referenceviewafterstartediting': function(
event ) {
var $referenceview = $( event.target ),
referenceview = $referenceview.data(
'referenceview' ),
- edittoolbar = $referenceview.data(
'edittoolbar' ),
- btnSave = edittoolbar.getButton( 'save' ),
+ edittoolbar = $referenceview.data(
'edittoolbar' );
+
+ if ( !edittoolbar ) {
+ return;
+ }
+
+ var btnSave = edittoolbar.getButton( 'save' ),
enableSave = referenceview.isValid() &&
!referenceview.isInitialValue();
btnSave[enableSave ? 'enable' : 'disable']();
@@ -69,8 +78,13 @@
}
var disable = referenceview.option( 'disabled' ),
- edittoolbar = $referenceview.data(
'edittoolbar' ),
- btnSave = edittoolbar.getButton( 'save' ),
+ edittoolbar = $referenceview.data(
'edittoolbar' );
+
+ if ( !edittoolbar ) {
+ return;
+ }
+
+ var btnSave = edittoolbar.getButton( 'save' ),
enableSave = ( referenceview.isValid() &&
!referenceview.isInitialValue() );
edittoolbar.option( 'disabled', disable );
--
To view, visit https://gerrit.wikimedia.org/r/247820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7105362b8dac335d85d80966872ccd836b7a5a19
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
