jenkins-bot has submitted this change and it was merged.
Change subject: Use listview.removeItem for reference removing in statementview
......................................................................
Use listview.removeItem for reference removing in statementview
`removeItem` triggers an event which is captured in `statementview` to update
the references counter.
Change-Id: I05d88246c2c0c61dbb22f517536b55bb8e321ef4
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
Thiemo Mättig (WMDE): Looks good to me, approved
Jeroen De Dauw: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index d445306..3479e2e 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -328,9 +328,7 @@
$newLi
.on( lia.prefixedEvent( 'afterstopediting' ),
function( event, dropValue ) {
if ( dropValue ) {
- liInstance.destroy();
- $newLi.remove();
- self._drawReferencesCounter();
+
self._referencesListview.removeItem( $newLi );
} else {
var newReferenceWithHash =
liInstance.value();
--
To view, visit https://gerrit.wikimedia.org/r/248830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05d88246c2c0c61dbb22f517536b55bb8e321ef4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.he...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
