jenkins-bot has submitted this change and it was merged. Change subject: Add block/inline icons ......................................................................
Add block/inline icons Change-Id: I7d07af249318e4f39d8e4a29d1fa3ccdd216e63b --- M modules/ext.templateDataGenerator.ui.css M modules/ext.templateDataGenerator.ui.tdDialog.js A modules/images/block-ltr.svg A modules/images/block-rtl.svg A modules/images/inline.svg 5 files changed, 30 insertions(+), 1 deletion(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ext.templateDataGenerator.ui.css b/modules/ext.templateDataGenerator.ui.css index 32128c5..e54c842 100644 --- a/modules/ext.templateDataGenerator.ui.css +++ b/modules/ext.templateDataGenerator.ui.css @@ -79,3 +79,13 @@ /* @embed */ background-image: url(images/parameter-set-ltr.svg); } + +.oo-ui-icon-template-format-block { + /* @embed */ + background-image: url(images/block-ltr.svg); +} + +.oo-ui-icon-template-format-inline { + /* @embed */ + background-image: url(images/inline.svg); +} diff --git a/modules/ext.templateDataGenerator.ui.tdDialog.js b/modules/ext.templateDataGenerator.ui.tdDialog.js index ea24769..3833cbb 100644 --- a/modules/ext.templateDataGenerator.ui.tdDialog.js +++ b/modules/ext.templateDataGenerator.ui.tdDialog.js @@ -157,13 +157,14 @@ this.templateFormatSelectWidget = new OO.ui.ButtonSelectWidget(); this.templateFormatSelectWidget.addItems( [ - // TODO: add nice icons? new OO.ui.ButtonOptionWidget( { data: 'inline', + icon: 'template-format-inline', label: mw.msg( 'templatedata-modal-format-inline' ) } ), new OO.ui.ButtonOptionWidget( { data: 'block', + icon: 'template-format-block', label: mw.msg( 'templatedata-modal-format-block' ) } ) ] ); diff --git a/modules/images/block-ltr.svg b/modules/images/block-ltr.svg new file mode 100644 index 0000000..ef37684 --- /dev/null +++ b/modules/images/block-ltr.svg @@ -0,0 +1,6 @@ +<?xml version="1.0" encoding="utf-8"?> +<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"> + <g id="block-ltr"> + <path d="M5 6h1v5H5zm2 1h8v3H7zm-2 6h1v5H5zm2 1h11v3H7z"/> + </g> +</svg> diff --git a/modules/images/block-rtl.svg b/modules/images/block-rtl.svg new file mode 100644 index 0000000..ce7908c --- /dev/null +++ b/modules/images/block-rtl.svg @@ -0,0 +1,6 @@ +<?xml version="1.0" encoding="utf-8"?> +<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"> + <g id="block-rtl"> + <path d="M19 6h-1v5h1zm-2 1H9v3h8zm2 6h-1v5h1zm-2 1H6v3h11z"/> + </g> +</svg> diff --git a/modules/images/inline.svg b/modules/images/inline.svg new file mode 100644 index 0000000..e6a59ec --- /dev/null +++ b/modules/images/inline.svg @@ -0,0 +1,6 @@ +<?xml version="1.0" encoding="utf-8"?> +<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"> + <g id="inline"> + <path d="M8 9v7h1V9zm7 0v7h1V9zM4 11v3h3v-3zm6 0v3h4v-3zm7 0v3h3v-3z"/> + </g> +</svg> -- To view, visit https://gerrit.wikimedia.org/r/243155 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d07af249318e4f39d8e4a29d1fa3ccdd216e63b Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/TemplateData Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits