Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/253364

Change subject: dynamicproxy: Don't try to restart redis when config changes
......................................................................

dynamicproxy: Don't try to restart redis when config changes

Is a stateful service, should be done manually

Change-Id: I6a0e60bf3ddeb2a7dea67b040f134080584d98f9
---
M modules/dynamicproxy/manifests/init.pp
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/64/253364/1

diff --git a/modules/dynamicproxy/manifests/init.pp 
b/modules/dynamicproxy/manifests/init.pp
index 2731b3f..da74ff0 100644
--- a/modules/dynamicproxy/manifests/init.pp
+++ b/modules/dynamicproxy/manifests/init.pp
@@ -49,13 +49,8 @@
             maxmemory  => $redis_maxmemory,
             slaveof    => $slaveof,
             dir        => '/var/lib/redis',
-        }
+        },
     }
-
-    # The redis module intentionally does not restart the redis
-    # service if the configuration changes, so we have to do this
-    # explicitly here.
-    File['/etc/redis/redis.conf'] ~> Service['redis-server']
 
     class { 'nginx':
         variant => 'extras',

-- 
To view, visit https://gerrit.wikimedia.org/r/253364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a0e60bf3ddeb2a7dea67b040f134080584d98f9
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <yuvipa...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to