Bearloga has uploaded a new change for review.
https://gerrit.wikimedia.org/r/253671
Change subject: Adds missing data notification system
......................................................................
Adds missing data notification system
Bug: T118872
Change-Id: I86731cc5c615647ba44e26be2e61fff13edad70f
---
M server.R
M ui.R
2 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/rainbow
refs/changes/71/253671/1
diff --git a/server.R b/server.R
index c677041..4320bb1 100644
--- a/server.R
+++ b/server.R
@@ -514,4 +514,29 @@
dyLegend(labelsDiv = "kpi_augmented_clickthroughs_series_legend")
})
+ # Check datasets for missing data and notify user which datasets are missing
data (if any)
+ output$message_menu <- renderMenu({
+ notifications <- list(
+ polloi::check_yesterday(desktop_dygraph_set, "Desktop events"),
+ polloi::check_past_week(desktop_load_data, "Desktop load times"),
+ polloi::check_yesterday(mobile_dygraph_set, "Mobile Web events"),
+ polloi::check_past_week(mobile_load_data, "Mobile Web load times"),
+ polloi::check_yesterday(android_dygraph_set, "Android events"),
+ polloi::check_past_week(android_load_data, "Android load times"),
+ polloi::check_yesterday(ios_dygraph_set, "iOS events"),
+ polloi::check_past_week(ios_load_data, "iOS load times"),
+ polloi::check_yesterday(dplyr::bind_rows(split_dataset), "API usage
data"),
+ polloi::check_past_week(dplyr::bind_rows(split_dataset), "API usage
data"),
+ polloi::check_yesterday(failure_dygraph_set, "zero results data"),
+ polloi::check_past_week(failure_dygraph_set, "zero results data"),
+ polloi::check_yesterday(suggestion_dygraph_set, "suggestions data"),
+ polloi::check_past_week(suggestion_dygraph_set, "suggestions data"),
+ polloi::check_yesterday(augmented_clickthroughs, "engagement % data"),
+ polloi::check_past_week(augmented_clickthroughs, "engagement % data"),
+ polloi::check_yesterday(user_page_visit_dataset, "survival times"),
+ polloi::check_past_week(user_page_visit_dataset, "survival times"))
+ notifications <- notifications[!sapply(notifications, is.null)]
+ return(dropdownMenu(type = "notifications", .list = notifications))
+ })
+
})
diff --git a/ui.R b/ui.R
index 87afcce..26e8de0 100644
--- a/ui.R
+++ b/ui.R
@@ -3,8 +3,7 @@
library(dygraphs)
#Header elements for the visualisation
-header <- dashboardHeader(title = "Search Metrics", disable = FALSE)
-
+header <- dashboardHeader(title = "Search Metrics",
dropdownMenuOutput("message_menu"), disable = FALSE)
#Sidebar elements for the search visualisations.
sidebar <- dashboardSidebar(
--
To view, visit https://gerrit.wikimedia.org/r/253671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86731cc5c615647ba44e26be2e61fff13edad70f
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/rainbow
Gerrit-Branch: master
Gerrit-Owner: Bearloga <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
