Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/253884
Change subject: Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense
......................................................................
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense
Bug: 117989
Change-Id: I7f9704999047dd73b784aeb186a8298aba657b1c
---
M .rubocop_todo.yml
M tests/browser/features/step_definitions/accept_language_steps.rb
M tests/browser/features/step_definitions/common_steps.rb
M tests/browser/features/step_definitions/ime_steps.rb
4 files changed, 4 insertions(+), 10 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/84/253884/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 3356981..6ae373f 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -34,9 +34,3 @@
# Configuration parameters: EnforcedStyle, SupportedStyles,
UseHashRocketsWithSymbolValues.
Style/HashSyntax:
Enabled: false
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForEmptyBraces, SupportedStyles.
-Style/SpaceInsideHashLiteralBraces:
- EnforcedStyle: no_space
diff --git a/tests/browser/features/step_definitions/accept_language_steps.rb
b/tests/browser/features/step_definitions/accept_language_steps.rb
index 08f1ca4..0c1035a 100644
--- a/tests/browser/features/step_definitions/accept_language_steps.rb
+++ b/tests/browser/features/step_definitions/accept_language_steps.rb
@@ -1,5 +1,5 @@
Given(/^that my browser's accept language is (.+)$/) do |language|
- browser = browser(test_name(@scenario), {language: language})
+ browser = browser(test_name(@scenario), { language: language })
$session_id = browser.driver.instance_variable_get(:@bridge).session_id
end
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index c61b6ab..7660fd9 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -7,14 +7,14 @@
Given(/^I set "(.*?)" as the interface language$/) do |language|
code = on(PanelPage).language_to_code(language)
- visit(PanelPage, :using_params => {:extra => "setlang=#{code}"})
+ visit(PanelPage, :using_params => { :extra => "setlang=#{code}" })
@original_content_font = on(PanelPage).content_font
@original_interface_font = on(PanelPage).interface_font
end
Given(/^I temporarily use "(.*?)" as the interface language$/) do |language|
code = on(PanelPage).language_to_code(language)
- visit(PanelPage, :using_params => {:extra => "uselang=#{code}"})
+ visit(PanelPage, :using_params => { :extra => "uselang=#{code}" })
end
Then(/^my interface language is "(.*?)"$/) do |language|
diff --git a/tests/browser/features/step_definitions/ime_steps.rb
b/tests/browser/features/step_definitions/ime_steps.rb
index 98c9f4b..96a2e2b 100644
--- a/tests/browser/features/step_definitions/ime_steps.rb
+++ b/tests/browser/features/step_definitions/ime_steps.rb
@@ -69,7 +69,7 @@
end
Given(/^I visit a random page with (.+) skin and (.+) as the interface
language$/) do |skin, language|
- visit(IMEPage, :using_params => {:extra =>
"useskin=#{skin.downcase}&uselang=#{on(IMEPage).language_to_code(language)}"})
+ visit(IMEPage, :using_params => { :extra =>
"useskin=#{skin.downcase}&uselang=#{on(IMEPage).language_to_code(language)}" })
end
Then(/^I should see the input method menu is not offscreen$/) do
--
To view, visit https://gerrit.wikimedia.org/r/253884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f9704999047dd73b784aeb186a8298aba657b1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
