Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/254337
Change subject: Prevent switching from unedited section directly into VE
......................................................................
Prevent switching from unedited section directly into VE
Bug: T117713
Change-Id: Iee9ae2bbe4757cb07e9aa2bd5f41a46c0ebb391a
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/37/254337/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 468ce54..9eb732e 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -535,7 +535,10 @@
if (
mw.config.get( 'wgAction' ) === 'submit' ||
- ( mw.config.get( 'wgAction' ) === 'edit' &&
wikitextModified )
+ ( mw.config.get( 'wgAction' ) === 'edit' &&
wikitextModified ) ||
+ // switching from section editing must prompt
because we can't
+ // keep changes from that (yet?)
+ $( 'input[name=wpSection]' ).val()
) {
mw.loader.using( 'ext.visualEditor.switching' )
.done( function () {
--
To view, visit https://gerrit.wikimedia.org/r/254337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee9ae2bbe4757cb07e9aa2bd5f41a46c0ebb391a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
