jenkins-bot has submitted this change and it was merged. Change subject: collapsibleTabs: Debounce resize event at 100ms instead of 500ms ......................................................................
collapsibleTabs: Debounce resize event at 100ms instead of 500ms A delay of 500ms is quite long and is a bad user experience. Resize should be more responsive than that. Matches other plugins that do the same thing, such as: http://www.paulirish.com/2009/throttled-smartresize-jquery-event-handler/ And also more in accordance with RAIL. https://developers.google.com/web/tools/chrome-devtools/profile/evaluate-performance/rail Change-Id: I076785f82a7786f16ca4fb1564a4972dd23cc56b --- M collapsibleTabs.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/collapsibleTabs.js b/collapsibleTabs.js index bf5ee1c..3c91e4e 100644 --- a/collapsibleTabs.js +++ b/collapsibleTabs.js @@ -26,7 +26,7 @@ // if we haven't already bound our resize handler, bind it now if ( !$.collapsibleTabs.boundEvent ) { - $( window ).on( 'resize', $.debounce( 500, function () { + $( window ).on( 'resize', $.debounce( 100, function () { $.collapsibleTabs.handleResize(); } ) ); $.collapsibleTabs.boundEvent = true; -- To view, visit https://gerrit.wikimedia.org/r/254329 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I076785f82a7786f16ca4fb1564a4972dd23cc56b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/Vector Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Edokter <er...@darcoury.nl> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
