jenkins-bot has submitted this change and it was merged.
Change subject: jserrorlog: Clean up use of deprecated functions
......................................................................
jserrorlog: Clean up use of deprecated functions
* Use Deferred .done() and .fail() instead of deprecated jQuery.ajax options.
* Use '.php' instead of wgScriptExtension (there was no .php5 variant even).
* Use 'location' directly instead of proxying via window.
* Whitelist 'mw' as global for JSHint.
Change-Id: I47ee7d1ac093814b5e44ebdbffa1272ecccf9fa1
---
M webfiles/twn.jserrorlog.js
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/webfiles/twn.jserrorlog.js b/webfiles/twn.jserrorlog.js
index d6dbd6c..f300701 100644
--- a/webfiles/twn.jserrorlog.js
+++ b/webfiles/twn.jserrorlog.js
@@ -1,19 +1,18 @@
+/*global mw */
window.onerror = function ( errorMsg, fileUrl, lineNumber ) {
$.ajax({
- url: mw.config.get( 'wgScriptPath' ) + '/webfiles/jserror' +
mw.config.get( 'wgScriptExtension' ),
+ url: mw.config.get( 'wgScriptPath' ) + '/webfiles/jserror.php',
type: 'POST',
data: {
errorMsg: errorMsg,
fileUrl: fileUrl,
lineNumber: lineNumber,
- windowLocation: window.location.href,
+ windowLocation: location.href,
errorStackTrace: new Error().stack // non-standard
property, not in all browsers
- },
- success: function () {
- mw.log('window.onerror> Logged error successfully',
arguments);
- },
- error: function () {
- mw.log('window.onerror> Logging error failed',
arguments);
}
+ }).done( function () {
+ mw.log('window.onerror> Logged error successfully', arguments);
+ }).fail( function () {
+ mw.log('window.onerror> Logging error failed', arguments);
});
};
--
To view, visit https://gerrit.wikimedia.org/r/254311
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47ee7d1ac093814b5e44ebdbffa1272ecccf9fa1
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
