jenkins-bot has submitted this change and it was merged. Change subject: Alphasort array values in onMessageCacheGet ......................................................................
Alphasort array values in onMessageCacheGet Fix some phpdoc issues Change-Id: I7b35edaf5638c0070ae10aeb6d170ca9ac61aa39 --- M WikimediaMessages.hooks.php 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/WikimediaMessages.hooks.php b/WikimediaMessages.hooks.php index 9f45771..b8ff966 100644 --- a/WikimediaMessages.hooks.php +++ b/WikimediaMessages.hooks.php @@ -23,18 +23,18 @@ global $wgLanguageCode, $wmfRealm; static $keys = array( + 'centralauth-contribs-locked', + 'centralauth-uwbr-intro', + 'centralauth-uwbr-registration-nodate', 'createacct-helpusername', 'createacct-imgcaptcha-help', 'feedback-termsofuse', 'globalrenamequeue-email-body-approved', 'globalrenamequeue-email-body-rejected', + 'mwoauthserver-invalid-user', + 'privacypage', 'sidebar', 'sulrenamewarning-usenew', - 'centralauth-contribs-locked', - 'centralauth-uwbr-intro', - 'centralauth-uwbr-registration-nodate', - 'privacypage', - 'mwoauthserver-invalid-user', ); if ( $wmfRealm === 'labs' && $lcKey === 'privacypage' ) { @@ -165,7 +165,7 @@ * * FIXME: Should have a specific message for WMF projects (T44231) * - * @param $msg The message to over-ride + * @param string $msg The message to over-ride * * @return bool */ @@ -177,7 +177,7 @@ /** * Set the message on GlobalBlocking IP block being triggered * - * @param $msg The message to over-ride + * @param string $msg The message to over-ride * * @return bool */ @@ -189,7 +189,7 @@ /** * Set the message on GlobalBlocking XFF block being triggered * - * @param $msg The message to over-ride + * @param string $msg The message to over-ride * * @return bool */ @@ -224,7 +224,9 @@ * Do not require it when licenses is in $wgForceUIMsgAsContentMsg, * to prevent checking each subpage of MediaWiki:Licenses. * + * @param $tpl * @return bool + * @throws ErrorPageError */ public static function onUploadFormInitial( $tpl ) { global $wgForceUIMsgAsContentMsg; -- To view, visit https://gerrit.wikimedia.org/r/254436 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b35edaf5638c0070ae10aeb6d170ca9ac61aa39 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikimediaMessages Gerrit-Branch: master Gerrit-Owner: Reedy <re...@wikimedia.org> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits