jenkins-bot has submitted this change and it was merged.
Change subject: DimensionsWidget: Check for numeric-ness of inputs
......................................................................
DimensionsWidget: Check for numeric-ness of inputs
DimensionsWidget asks the user for pixels but didn't enforce a
validation pattern on its inputs.
Change-Id: I1628e7cbc076e7eb4cd2c0bc16f155197e317cc2
---
M src/ui/widgets/ve.ui.DimensionsWidget.js
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/widgets/ve.ui.DimensionsWidget.js
b/src/ui/widgets/ve.ui.DimensionsWidget.js
index 3cdfefb..87ed624 100644
--- a/src/ui/widgets/ve.ui.DimensionsWidget.js
+++ b/src/ui/widgets/ve.ui.DimensionsWidget.js
@@ -25,8 +25,12 @@
// Parent constructor
OO.ui.Widget.call( this, config );
- this.widthInput = new OO.ui.TextInputWidget( { validate:
config.validate } );
- this.heightInput = new OO.ui.TextInputWidget( { validate:
config.validate } );
+ this.widthInput = new OO.ui.TextInputWidget( {
+ validate: config.validate || $.isNumeric
+ } );
+ this.heightInput = new OO.ui.TextInputWidget( {
+ validate: config.validate || $.isNumeric
+ } );
this.defaults = config.defaults || { width: '', height: '' };
this.renderDefaults();
--
To view, visit https://gerrit.wikimedia.org/r/254597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1628e7cbc076e7eb4cd2c0bc16f155197e317cc2
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Ferdbold <fbol...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
