Yaron Koren has submitted this change and it was merged.
Change subject: Better display of Boolean values in query results
......................................................................
Better display of Boolean values in query results
Change-Id: I8d1e391f16eaeefc0e9f593328dffa140ddabe9f
---
M CargoQueryDisplayer.php
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Yaron Koren: Checked; Looks good to me, approved
jenkins-bot: Verified
diff --git a/CargoQueryDisplayer.php b/CargoQueryDisplayer.php
index 7eada21..d386a0d 100644
--- a/CargoQueryDisplayer.php
+++ b/CargoQueryDisplayer.php
@@ -129,6 +129,12 @@
}
}
$text = self::formatDateFieldValue(
$value, $datePrecision, $fieldType );
+ } elseif ( $fieldType == 'Boolean' ) {
+ // Displaying a check mark for "yes"
+ // and an x mark for "no" would be
+ // cool, but those are apparently far
+ // from universal symbols.
+ $text = ( $value == true ) ? wfMessage(
'htmlform-yes' )->text() : wfMessage( 'htmlform-no' )->text();
} else {
$text = self::formatFieldValue( $value,
$fieldType, $fieldDescription, $this->mParser );
}
--
To view, visit https://gerrit.wikimedia.org/r/254921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d1e391f16eaeefc0e9f593328dffa140ddabe9f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
