Bartosz Dziewoński has submitted this change and it was merged. Change subject: OOjs UI: Backport 4fbbc737c86b500c11bbb471ec1001c50ab8853c ......................................................................
OOjs UI: Backport 4fbbc737c86b500c11bbb471ec1001c50ab8853c We totally forgot to use a localisation message we carefully introduced. We're even sending the message to the client correctly, just not using it. Has plenty of translations and this is a really annoying kind of issue to notice on a non-English wiki. Change-Id: Ifc2cb5ac5930c8d3c4b0da295d5d868d442630b2 --- M resources/lib/oojs-ui/oojs-ui.js 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/lib/oojs-ui/oojs-ui.js b/resources/lib/oojs-ui/oojs-ui.js index 2565fb5..a00b973 100644 --- a/resources/lib/oojs-ui/oojs-ui.js +++ b/resources/lib/oojs-ui/oojs-ui.js @@ -1,3 +1,11 @@ +/* + * Local backports: + * + * - 4fbbc737c86b500c11bbb471ec1001c50ab8853c + * SelectFileWidget: Use i18n string for button label + * We totally forgot to use a localisation message we carefully introduced. + */ + /*! * OOjs UI v0.13.3 * https://www.mediawiki.org/wiki/OOjs_UI @@ -14234,7 +14242,7 @@ this.selectButton = new OO.ui.ButtonWidget( { classes: [ 'oo-ui-selectFileWidget-selectButton' ], - label: 'Select a file', + label: OO.ui.msg( 'ooui-selectfile-button-select' ), disabled: this.disabled || !this.isSupported } ); -- To view, visit https://gerrit.wikimedia.org/r/255024 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc2cb5ac5930c8d3c4b0da295d5d868d442630b2 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
