jenkins-bot has submitted this change and it was merged.
Change subject: Special:Contribs: autofocus to 'target' if target hasn't been
specified or in non-newbies mode
......................................................................
Special:Contribs: autofocus to 'target' if target hasn't been specified or in
non-newbies mode
Target field doesn't work in newbies mode so users doesn't need to enter in
that field
newbies mode also. This is not a huge issue normally but annoying when you're
on a tablet
or mobile where the autofocus makes the screen keyboard be shown when you visit
the page.
Bug: T117397
Change-Id: Ic6fd2fb2421325f748fccb2a5432e7713d0dcbb0
---
M includes/specials/SpecialContributions.php
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialContributions.php
b/includes/specials/SpecialContributions.php
index 81668e1..5f7c587 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -517,8 +517,13 @@
'mw-ui-input-inline',
'mw-autocomplete-user', // used by
mediawiki.userSuggest
),
- ) + ( $this->opts['target'] ? array() : array(
'autofocus' ) )
+ ) + (
+ // Only autofocus if target hasn't been
specified or in non-newbies mode
+ ( $this->opts['contribs'] === 'newbie' ||
$this->opts['target'] )
+ ? array() : array( 'autofocus' => true )
+ )
);
+
$targetSelection = Html::rawElement(
'td',
array( 'colspan' => 2 ),
--
To view, visit https://gerrit.wikimedia.org/r/252632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6fd2fb2421325f748fccb2a5432e7713d0dcbb0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Glaisher <glaisher.w...@gmail.com>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Glaisher <glaisher.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
