Edward Chernenko has uploaded a new change for review. https://gerrit.wikimedia.org/r/255927
Change subject: Fix "Undefined property: DiffEngine::$seq" under HHVM in DairikiDiff.php ...................................................................... Fix "Undefined property: DiffEngine::$seq" under HHVM in DairikiDiff.php Bug: T116266 Change-Id: I94ed1ce946b4c3e757405167d6c4530a5863a220 --- M includes/diff/DairikiDiff.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/27/255927/1 diff --git a/includes/diff/DairikiDiff.php b/includes/diff/DairikiDiff.php index 264c87f..7401992 100644 --- a/includes/diff/DairikiDiff.php +++ b/includes/diff/DairikiDiff.php @@ -296,9 +296,9 @@ $this->xchanged = $this->ychanged = array(); $this->xv = $this->yv = array(); $this->xind = $this->yind = array(); - unset( $this->seq ); - unset( $this->in_seq ); - unset( $this->lcs ); + $this->seq = array(); + $this->in_seq = array(); + $this->lcs = 0; // Skip leading common lines. for ( $skip = 0; $skip < $n_from && $skip < $n_to; $skip++ ) { -- To view, visit https://gerrit.wikimedia.org/r/255927 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I94ed1ce946b4c3e757405167d6c4530a5863a220 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Edward Chernenko <edwards...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits