Dzahn has submitted this change and it was merged. Change subject: eventlogging, varnish: fix last 2 quoting warnings ......................................................................
eventlogging, varnish: fix last 2 quoting warnings These are the last 2 lint warnings of the type "double quoted string containing no variable" across the entire repo (except submodule cassandra). For eventlogging i actually replace the quotes, for varnish i just make lint ignore it. After fixing these we can re-enable that particular lint check. Bug:T93645 Change-Id: Ic834d12574d5d5eb04c9701c83c8250451f7d693 --- M modules/eventlogging/manifests/monitoring/graphite.pp M modules/varnish/manifests/instance.pp 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/modules/eventlogging/manifests/monitoring/graphite.pp b/modules/eventlogging/manifests/monitoring/graphite.pp index e7553be..a10606a 100644 --- a/modules/eventlogging/manifests/monitoring/graphite.pp +++ b/modules/eventlogging/manifests/monitoring/graphite.pp @@ -64,7 +64,7 @@ # kafka pipeline monitoring::graphite_threshold { 'eventlogging_overall_inserted_rate': description => 'Overall insertion rate from MySQL consumer', - metric => "eventlogging.overall.inserted.rate", + metric => 'eventlogging.overall.inserted.rate', warning => 100, critical => 10, percentage => 20, # At least 3 of the (25 - 10) = 15 readings diff --git a/modules/varnish/manifests/instance.pp b/modules/varnish/manifests/instance.pp index fa73ae2..dfeefd0 100644 --- a/modules/varnish/manifests/instance.pp +++ b/modules/varnish/manifests/instance.pp @@ -48,7 +48,7 @@ $inst = $name } - # lint:ignore:quoted_booleans + # lint:ignore:quoted_booleans lint:ignore:double_quoted_strings if inline_template("<%= @directors.map{|k,v| v['dynamic'] }.include?('yes') %>") == "true" { $use_dynamic_directors = true } else { -- To view, visit https://gerrit.wikimedia.org/r/256472 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic834d12574d5d5eb04c9701c83c8250451f7d693 Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: BBlack <bbl...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits