jenkins-bot has submitted this change and it was merged. Change subject: Do SearchUpdate::indexTitle after search-update is supported check ......................................................................
Do SearchUpdate::indexTitle after search-update is supported check If the SearchEngine does not support search-update, then $indexTitle is not used and thus no need to create it in that case. Change-Id: I487d06274e921223a3bcb5af846b48b7c2b8065e --- M includes/deferred/SearchUpdate.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Kinzler: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/deferred/SearchUpdate.php b/includes/deferred/SearchUpdate.php index 6ed1d00..867fc61 100644 --- a/includes/deferred/SearchUpdate.php +++ b/includes/deferred/SearchUpdate.php @@ -82,11 +82,11 @@ foreach ( SearchEngine::getSearchTypes() as $type ) { $search = SearchEngine::create( $type ); - $indexTitle = $this->indexTitle( $search ); if ( !$search->supports( 'search-update' ) ) { continue; } + $indexTitle = $this->indexTitle( $search ); $normalTitle = $search->normalizeText( $indexTitle ); if ( $page === null ) { -- To view, visit https://gerrit.wikimedia.org/r/256420 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I487d06274e921223a3bcb5af846b48b7c2b8065e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits