jenkins-bot has submitted this change and it was merged.
Change subject: Add return type
......................................................................
Add return type
Add false return null
Change-Id: Ic68232b9d94a7b2938009421f1db598c0eb57d35
---
M src/IPSet.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
BBlack: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/src/IPSet.php b/src/IPSet.php
index 1c79f06..249d84e 100644
--- a/src/IPSet.php
+++ b/src/IPSet.php
@@ -207,6 +207,8 @@
return $node;
}
}
+ // Unreachable, but fixes missing return statement
+ return null;
}
/**
@@ -215,6 +217,8 @@
* @param array &$node Tree node to optimize, by-reference
*
* e.g.: 8.0.0.0/8 + 9.0.0.0/8 -> 8.0.0.0/7
+ *
+ * @return bool
*/
private static function recOptimize( &$node ) {
if ( $node[0] !== false && $node[0] !== true &&
self::recOptimize( $node[0] ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/254410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic68232b9d94a7b2938009421f1db598c0eb57d35
Gerrit-PatchSet: 1
Gerrit-Project: IPSet
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
