Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/256916
Change subject: Make browsertest check for including Jenkins.php more specific
......................................................................
Make browsertest check for including Jenkins.php more specific
I would like the check to be more specific to whatever
job name or something specific to Cindy the browser test bot.
(i'm not totally sure this works for Cindy as I don't know
what the job is called or if really runs on jenkins or what)
right now, this stuff all gets loaded now for Wikibase
browser tests, yet we don't load MwEmbedSupport etc.
that Jenkins.php requires.
I think these tests should be more specific to the Cirrus
jobs.
Bug: T120360
Change-Id: Ieab7d72f005db3d1304014ef7620e44479564c02
---
M CirrusSearch.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/16/256916/1
diff --git a/CirrusSearch.php b/CirrusSearch.php
index 49135ec..cd7cd4e 100644
--- a/CirrusSearch.php
+++ b/CirrusSearch.php
@@ -900,7 +900,7 @@
* Note that it is only hooked for browser tests.
*/
if ( isset( $wgWikimediaJenkinsCI ) && $wgWikimediaJenkinsCI === true && (
- PHP_SAPI !== 'cli' || // If we're not in the CLI then this
is certainly a browser test
+ PHP_SAPI !== 'cli' && // If we're not in the CLI then this is
certainly a browser test
strpos( getenv( 'JOB_NAME' ), 'browsertests' ) !== false ) ) {
require( __DIR__ . '/tests/jenkins/Jenkins.php' );
}
--
To view, visit https://gerrit.wikimedia.org/r/256916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieab7d72f005db3d1304014ef7620e44479564c02
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
