jenkins-bot has submitted this change and it was merged.
Change subject: Replace injectSpinner/removeSpinner with jquery.spinner
......................................................................
Replace injectSpinner/removeSpinner with jquery.spinner
Bug: T92991
Change-Id: I863014a72c8722f4388516a4afb9ccb22a540910
---
M extension.json
M modules/ext.codereview.loaddiff.js
2 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
He7d3r: Looks good to me, but someone else must approve
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 3e5be8f..b6dc963 100644
--- a/extension.json
+++ b/extension.json
@@ -97,7 +97,8 @@
"styles": "ext.codereview.styles.css"
},
"ext.codereview.loaddiff": {
- "scripts": "ext.codereview.loaddiff.js"
+ "scripts": "ext.codereview.loaddiff.js",
+ "dependencies": "jquery.spinner"
},
"ext.codereview.tooltips": {
"scripts": "ext.codereview.tooltips.js",
diff --git a/modules/ext.codereview.loaddiff.js
b/modules/ext.codereview.loaddiff.js
index 2302d68..6e4fb90 100644
--- a/modules/ext.codereview.loaddiff.js
+++ b/modules/ext.codereview.loaddiff.js
@@ -6,7 +6,7 @@
loadDiff : function(repo, rev) {
var apiPath = mw.config.get( 'wgScriptPath' ) + '/api.php';
- injectSpinner( CodeReview.diffTarget(), 'codereview-diff' );
+ $( CodeReview.diffTarget() ).injectSpinner( 'codereview-diff' );
try {
$.ajax({
url: apiPath,
@@ -19,11 +19,11 @@
dataType : 'json',
success : function( data ) {
CodeReview.decodeAndShowDiff( data );
- removeSpinner( 'codereview-diff' );
+ $.removeSpinner( 'codereview-diff' );
}
});
} catch ( e ) {
- removeSpinner( 'codereview-diff' );
+ $.removeSpinner( 'codereview-diff' );
if ( window.location.hostname === 'localhost' ) {
alert( 'Your browser blocks XMLHttpRequest to
"localhost", try using a real hostname for development/testing.' );
}
--
To view, visit https://gerrit.wikimedia.org/r/254177
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I863014a72c8722f4388516a4afb9ccb22a540910
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: He7d3r <he7...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
