Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/256953

Change subject: SpecialWatchlist: Don't display '0' in the selector when 'all' 
is chosen
......................................................................

SpecialWatchlist: Don't display '0' in the selector when 'all' is chosen

Follow-up to f3daab99f71eb3e41ae472deb8a71d7d6cbd42db.

Change-Id: I6ffc9b93bc1bd6111224c06f124b1bd01107bbd5
---
M includes/specials/SpecialWatchlist.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/53/256953/1

diff --git a/includes/specials/SpecialWatchlist.php 
b/includes/specials/SpecialWatchlist.php
index 34c44d4..9265ba6 100644
--- a/includes/specials/SpecialWatchlist.php
+++ b/includes/specials/SpecialWatchlist.php
@@ -529,7 +529,7 @@
 
                $selected = (string)$options['days'];
                // add the currently selected value, if it isn't available 
already
-               if ( !in_array( $selected, $days ) ) {
+               if ( $selected !== '0' && !in_array( $selected, $days ) ) {
                        $days[] = $selected;
                }
 
@@ -547,7 +547,7 @@
 
                // 'all' option
                $name = $this->msg( 'watchlistall2' )->text();
-               $value = 0;
+               $value = '0';
                $select->addOption( $name, $value );
 
                return $select->getHTML() . "\n<br />\n";

-- 
To view, visit https://gerrit.wikimedia.org/r/256953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ffc9b93bc1bd6111224c06f124b1bd01107bbd5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to