Giuseppe Lavagetto has submitted this change and it was merged.
Change subject: Fix race condition in clearing the alerts
......................................................................
Fix race condition in clearing the alerts
It could happen that a pool was below the depooling threshold by just
removing one server, and that would mean we would never clear the alert
when that server was repooled.
Change-Id: I9e660931515a39c2f435146a20ea411885483d56
---
M pybal/pybal.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pybal/pybal.py b/pybal/pybal.py
index e34bc66..4f7863b 100755
--- a/pybal/pybal.py
+++ b/pybal/pybal.py
@@ -387,6 +387,9 @@
# See if we can depool any servers that could not be depooled before
while len(self.pooledDownServers) > 0 and self.canDepool():
self.depool(self.pooledDownServers.pop())
+
+ # See if we can clear the alert
+ if len(self.pooledDownServers) == 0:
instrumentation.Alerts.delAlert(self.lvsservice.name)
def canDepool(self):
--
To view, visit https://gerrit.wikimedia.org/r/257310
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e660931515a39c2f435146a20ea411885483d56
Gerrit-PatchSet: 3
Gerrit-Project: operations/debs/pybal
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Mark Bergsma <m...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
