[MediaWiki-commits] [Gerrit] Nice execute button and data updated clock - change (wikidata...rdf)

[Jonas Kress (WMDE) (Code Review)]

Jonas Kress (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/257570

Change subject: Nice execute button and data updated clock
......................................................................

Nice execute button and data updated clock

Change-Id: I2820fcdd5537bd500ef91ae6bb66069496093573
---
M gui/index.html
M gui/wikibase/queryService/ui/App.js
2 files changed, 16 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf 
refs/changes/70/257570/1

diff --git a/gui/index.html b/gui/index.html
index 6c2f8ab..934f7ad 100644
--- a/gui/index.html
+++ b/gui/index.html
@@ -77,12 +77,16 @@
                                                <button type="button" 
class="close" data-dismiss="alert" aria-label="Close">
                                                        <span 
aria-hidden="true">&times;</span>
                                                </button>
-                                               Press <i>[CTRL-SPACE]</i> to 
activate auto completion. Data last updated: <span 
id="dbUpdated">[connecting]</span>
+                                               Press <i>[CTRL-SPACE]</i> to 
activate auto completion.
                                        </div>
                                        <nav class="navbar navbar-default">
                                                <div class="navbar-form 
navbar-left">
                                                        <div class="form-group">
-                                                               <input 
class="btn btn-default" type="submit" id="execute-button" value="Execute"> 
<input class="btn btn-default" type="reset" id="clear-button" value="Clear">
+                                                               <button 
type="submit" class="btn btn-danger" id="execute-button" value="Execute">
+                                                                       <span 
class="glyphicon glyphicon-play" aria-hidden="true"></span> Execute
+                                                               </button>
+                                                                <input 
class="btn btn-default" type="reset" id="clear-button" value="Clear">
+                                                               <span 
class="dataUpdated glyphicon glyphicon-time" aria-hidden="true"></span>
                                                        </div>
                                                </div>
                                                <ul class="nav navbar-nav 
navbar-right" id="total">
diff --git a/gui/wikibase/queryService/ui/App.js 
b/gui/wikibase/queryService/ui/App.js
index fb682bc..d748a40 100644
--- a/gui/wikibase/queryService/ui/App.js
+++ b/gui/wikibase/queryService/ui/App.js
@@ -149,11 +149,16 @@
         * @private
         **/
        SELF.prototype._initDataUpdated = function() {
-               this._sparqlApi.queryDataUpdatedTime().done( function( time ){
-                       $( '#dbUpdated' ).text( time );
-               } ).fail(function(){
-                       $( '#dbUpdated' ).text( '[unable to connect]' );
-               });
+               var self = this;
+
+               $( '.dataUpdated' ).hover(function() {
+                   var e = $(this);
+                   self._sparqlApi.queryDataUpdatedTime().done( function( time 
){
+                        e.popover( {content: 'Data updated: ' + time} 
).popover( 'show' );
+                   } ).fail(function(){
+                        e.popover({content: '[unable to connect]'} ).popover( 
'show' );
+                   });
+               }, function() { var e = $( this ); e.popover( 'hide' ) });
        };
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/257570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2820fcdd5537bd500ef91ae6bb66069496093573
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits