Sbisson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/257655
Change subject: Remove hardcoded token from patrol link
......................................................................
Remove hardcoded token from patrol link
Bug: T118225
Change-Id: Ia3875725e32d8e366b1b2aa8151ad36ff43c4c49
---
M includes/Formatter/RevisionViewFormatter.php
M includes/UrlGenerator.php
2 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/55/257655/1
diff --git a/includes/Formatter/RevisionViewFormatter.php
b/includes/Formatter/RevisionViewFormatter.php
index fa063c7..7daca15 100644
--- a/includes/Formatter/RevisionViewFormatter.php
+++ b/includes/Formatter/RevisionViewFormatter.php
@@ -131,8 +131,7 @@
$links['markPatrolled'] =
$this->urlGenerator->markRevisionPatrolledAction(
$title,
$workflowId,
- $recentChange,
- $user->getEditToken(
$recentChange->getAttribute( 'rc_id' ) )
+ $recentChange
);
}
}
diff --git a/includes/UrlGenerator.php b/includes/UrlGenerator.php
index 20ab208..3c58f1a 100644
--- a/includes/UrlGenerator.php
+++ b/includes/UrlGenerator.php
@@ -842,19 +842,17 @@
* @param Title|null $title
* @param UUID $workflowId
* @param RecentChange $rc
- * @param string $token
* @return Anchor
* @throws FlowException
* @throws InvalidInputException
*/
- public function markRevisionPatrolledAction( Title $title = null, UUID
$workflowId, RecentChange $rc, $token ) {
+ public function markRevisionPatrolledAction( Title $title = null, UUID
$workflowId, RecentChange $rc ) {
return new Anchor(
wfMessage( 'flow-mark-revision-patrolled-link-text'
)->text(),
$this->resolveTitle( $title, $workflowId ),
array(
'action' => 'markpatrolled',
- 'rcid' => $rc->getAttribute( 'rc_id' ),
- 'token' => $token
+ 'rcid' => $rc->getAttribute( 'rc_id' )
)
);
}
--
To view, visit https://gerrit.wikimedia.org/r/257655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3875725e32d8e366b1b2aa8151ad36ff43c4c49
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
